Conversation
There was a problem hiding this comment.
Pull Request Overview
Optimizes warning collection by switching from a loop to a list comprehension and turns on performance linting in Ruff.
- Replaces manual
for+appendwith a singlewarnings.extend([...])comprehension. - Updates
ruff.tomlto enable thePERFlint rules and add a trailing comma to theIentry.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/generate_osv_advisories.py | Switch to list comprehension for leading-zero warnings |
| ruff.toml | Add 'I', formatting and enable the PERF performance rules |
Comments suppressed due to low confidence (1)
scripts/generate_osv_advisories.py:152
- Add or update a test case that includes version components with leading zeros to verify this new list comprehension path triggers as expected.
for component in [
| warnings.append('components should not be prefixed with leading zeros') | ||
| warnings.extend( | ||
| [ | ||
| 'components should not be prefixed with leading zeros' |
There was a problem hiding this comment.
[nitpick] Including the actual component value in the warning (for example, f"component '{component}' should not be prefixed with leading zeros") would provide more context when debugging.
Suggested change
| 'components should not be prefixed with leading zeros' | |
| f"component '{component}' should not be prefixed with leading zeros" |
Collaborator
Author
There was a problem hiding this comment.
it should be very obvious what component has the leading zeros when reviewing the advisory with the warning, so I don't think this is needed
nzlaura
approved these changes
May 22, 2025
jonholdsworth
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technically this is faster than how we were doing it previously, though in practice it won't be measurable but I think it's still nice to do along with enabling the performance lint rules rather than doing an inline disable